Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Advisory] File Downloader cookie leak #32450

Open
dirkf opened this issue Jul 18, 2023 · 2 comments
Open

[Security Advisory] File Downloader cookie leak #32450

dirkf opened this issue Jul 18, 2023 · 2 comments

Comments

@dirkf
Copy link
Contributor

dirkf commented Jul 18, 2023

During file downloads, youtube-dl (or the external downloaders that it invokes) may leak cookies on HTTP redirects to a different host, or when the host for fragments being downloaded differs from their parent manifest's host.

Please refer to this security advisory for further details.

Youtube-dl users who are concerned about this issue should install a new version of the program from the nightly build repository: versions dated 2023-07-18 or later incorporate changes to remediate the issue. The next stable release will also include these remediations.

If updating is not possible, please refer to the linked advisory for suggested work-arounds.

@a-pav
Copy link

a-pav commented Dec 3, 2023

From the advisory:

At the file download stage, all cookies are passed by youtube-dl to the file downloader as a Cookie header, thereby losing their scope.

Looks like youtube-dl version 2021.12.17 is affected, even when the cookies are passed as scoped, Netscape-formatted text file like --cookies ./cookies.txt. Right?

Can I apply the patch to my youtube-dl 2021.12.17 installation, or does it require a newer base?

@dirkf
Copy link
Contributor Author

dirkf commented Dec 3, 2023

Do read the issue text:

Youtube-dl users who are concerned about this issue should install a new version of the program from the nightly build repository

The changes are quite extensive and relate to a master code version 18 months later than the 2021.12 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@dirkf @a-pav and others