Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All exceptions are caught #97

Open
rovansteen opened this issue Dec 19, 2016 · 4 comments
Open

All exceptions are caught #97

rovansteen opened this issue Dec 19, 2016 · 4 comments
Assignees
Milestone

Comments

@rovansteen
Copy link

Why are all the exceptions caught? This makes debugging really difficult, because there will be no logs or for example in my Symfony application nothing shows up in the profiler. Am I missing something here?

@viniychuk
Copy link
Member

@rovansteen Will let it slip in Symfony bundle. Ideally – exceptions will be delivered with the descriptive information so you can easily see what's the problem is. That was a big topic of discussion and idea was to return response in any case... but again, we have to keep the original exception message if it's generic.

@rovansteen
Copy link
Author

@viniychuk yes I understand that. Perhaps having some sort of middleware where you can do something with the exception, like log it or send it to a service like Sentry will help with debugging a lot while still being able to send a useful response back to the client.

@garte
Copy link

garte commented Feb 20, 2017

Just a workaround: I've written my own ExecutionContext class and invoke it via the given parameter "graphql.execution_context.class". This way I can override the "addError" method and log accordingly.

@lox
Copy link

lox commented Apr 12, 2017

This issue makes testing and debugging really difficult. It seems like there are lots of places where \Exception is caught. Perhaps a pluggable exception handler would be a good way of dealing with the problem?

@portey portey added this to the 2.0 milestone Dec 7, 2017
@portey portey self-assigned this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants