Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can extract the Parser as a standalone package? #243

Open
leoloso opened this issue Apr 2, 2020 · 2 comments
Open

Can extract the Parser as a standalone package? #243

leoloso opened this issue Apr 2, 2020 · 2 comments

Comments

@leoloso
Copy link

leoloso commented Apr 2, 2020

Hi! I'm currently using only the Parser from Youshido, and not the full GraphQL server. I use it to power another GraphQL server in PHP which I'm developing, GraphQL by PoP (I'm in the process of launching it, soon).

Would it be possible to extract the Parser as a standalone solution, and then have the Youshido server simply include it as a dependency?

I know that this is not really needed, but it makes the whole solution nicer and cleaner, and this parser works really well as a standalone solution. (I also tried the one from webonyx, but that one doesn't work in my project, because it has a hard dependency on its own schema)

Also, I've seen that this package is looking for new maintainers, and I wonder if it would be easier to find them for smaller tasks. Then, someone could become the maintainer just for the parser and keep it updated with all the upcoming changes to the GraphQL spec, which are already happening (eg: the "&" symbol to declare all implemented interfaces).

Thanks

@Jalle19
Copy link
Collaborator

Jalle19 commented Apr 8, 2020

Sounds like a good idea, I've seen similar discussions in other implementations (everyone needs a lexer + parser and it's cumbersome to re-implement the wheel all the time).

@leoloso
Copy link
Author

leoloso commented Apr 12, 2020

That would be wonderful! How to kick-start this development? Should I try to do it? Or anyone else can take care of it? (I'm not experienced with Youshido's codebase, just scratching the surface, and this issue will most likely involve changes in its architecture...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants