Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Variable "$basename" seems have no effect #70

Open
imwis opened this issue Jul 10, 2019 · 2 comments
Open

Variable "$basename" seems have no effect #70

imwis opened this issue Jul 10, 2019 · 2 comments

Comments

@imwis
Copy link
Contributor

imwis commented Jul 10, 2019

Hi! I noticed a problem with the variable "$basename" in "LEOrder.php".
I wanted to set a custom directory to store my certificates for each domain. So I tried defining the "$basename" variable. I found the new certificate would still be stored in the directory that "$certificateKeys"(LEClient.php) defined. The $basename seems not to take effect.
Could you please help me solve the problem?

Thanks!

@jeroenv3
Copy link

jeroenv3 commented Oct 9, 2019

I've been struggling with that as well, you may also be using the custom certificate keys directory in the client config, you can set the domain name there, it doesnt seem to look at $basename if you set the custom cert path

$client = new LEClient($email, true, LEClient::LOG_STATUS, 'keys/'); // Initiating a LEClient and select custom certificate keys directory (string or array)

@yourivw
Copy link
Owner

yourivw commented Mar 27, 2020

My guess is that this functionality has been lost in one of the early PRs. Some PRs were pushed, which implemented more flexibility with the $certificateKeys and $accountKeys variables. The basename variable is now only used for the CSR, for the certificate's CN.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants