Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 评论表情有点问题 #19

Open
if1y opened this issue Aug 3, 2020 · 2 comments
Open

[BUG] 评论表情有点问题 #19

if1y opened this issue Aug 3, 2020 · 2 comments

Comments

@if1y
Copy link
Contributor

if1y commented Aug 3, 2020

我又来了hhhh

主要是两个问题:

  1. image 第二行中间这个手势的表情应该弄错了吧?点击之后的命名是image,感觉应该是这个 image

  2. 部分表情命名错误,比如 image 应该是chaiquan_love 而非 chaoquan_love

然后顺便问一下表情命名除了改动OwO.php 中的引用名称,还有哪里需要同步调整的么,我想整一下改成中文的,这样便于理解(主要体现在邮件提醒、插入后的文本框这几种无法解析出图片的地方),我改好之后可以发个pr,或者大佬直接改了也是可以的

@if1y if1y closed this as completed Feb 22, 2021
@if1y if1y mentioned this issue Apr 1, 2021
@if1y
Copy link
Contributor Author

if1y commented Apr 1, 2021

已pr,请审核:

排查: haha 被指向了 yo.png,而 yo 也是指向 yo.png
处理: 检查 /IMG/bq/ 发现这个 haha 的图片素材实际命名为 233.png,出于统一就按 233 修改了

另:

个人计划把编辑状态下的引用名称改成中文(即使用 @(哈哈) 而非 @(haha))以增强可读性。我看其他主题也有不少用的是中文,兼容性方面应该没有问题。考虑到这个是公共主题,擅自更改容易给其它使用者造成后果,所以我大概会自行修改使用,如果作者觉得可以,我再单独pr

@if1y if1y reopened this Apr 1, 2021
@youranreus
Copy link
Owner

真是太好不过了,如果可以实现的话发pr就OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants