Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message to user clearer when updating an organisation identifier in Publisher #1352

Open
siwhitehouse opened this issue Jan 19, 2024 · 8 comments
Assignees
Labels
Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS

Comments

@siwhitehouse
Copy link
Collaborator

I have set up an account in Staging to troubleshoot and replicate issues. The organisation name is 'simon-troubleshooting'. For the issue I am trying to troubleshoot I need to update the organisation reference.

I go to https://iatipublisher-staging.yipl.com.np/organisation/organisation_identifier and I change the country, the Organisation Registration Agency and the Registration Number. I see that the organisation-identifier field is updated to the correct identifier and I have checked that this identifier also appears in the IATI Registry Staging site,

When I click on "Save and Exit" I am presented with the error message "Please enter correct identifier as present in IATI Registry." and the organisation-identifier field changes to the previous/existing identifier. I am unable to update the organisation-identifier.

I have been able to replicate this with two other publishers, chosen at random, from the publishes listed at https://staging.iatiregistry.org/publisher/

@siwhitehouse siwhitehouse added Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS labels Jan 19, 2024
@praweshsth
Copy link
Collaborator

@siwhitehouse Please send us the whole process and data and if possible a screen record of it so that we can understand the issue.

@siwhitehouse
Copy link
Collaborator Author

Logged in as user 'simon-troubleshooting I go to https://iatipublisher-staging.yipl.com.np/organisation/organisation_identifier

image

I update the organisation identifier to the one whose error I want to replicate

image

That publisher exists in the staging site of the Registry, with the same identifier I have constructed in Publisher.

image

When I click on "Save and Exit".

image

I am presented with the error message "Please enter correct identifier as present in IATI Registry." and the organisation-identifier field changes to the previous/existing identifier. I am unable to update the organisation-identifier.

Please let me know when you have replicated this and I will obscure the organisation name from the images posted.

@praweshsth
Copy link
Collaborator

@siwhitehouse thank you for sharing the process. To change the organisation-identifier:

  • publisher id associated with organisation-identifier in IATI Registry should match with the publisher id and organisation-identifier in IATI publisher.

In your case the publisher id is not same as in IATI Registry staging. Hence it is not allowed to change.

@siwhitehouse
Copy link
Collaborator Author

@praweshsth They look exactly the same to me. What differences do you see, please?

@praweshsth
Copy link
Collaborator

@siwhitehouse the publisher ID of 'Simon-troubleshooting' is trouble and when you created the organisation in IATI Publisher, same ID was also created in IATI Registry. Both in publisher and registry, the publisher ID and organisation identifier are associated.

You tried to change the organisation identifier of 'Simon-troubleshooting' but in IATI registry the organisation identifier is not changed. And when you tried to change, it is showing the error.

@praweshsth
Copy link
Collaborator

@siwhitehouse @dan-odsc

Should we close this issue, because we have added JICA in staging which is mentioned in another issue #1340 ?

@dan-odsc
Copy link
Collaborator

dan-odsc commented Feb 1, 2024

Moving to proposed as there is further scoping/defining to do based on our call yesterday.

@emmajclegg emmajclegg changed the title Unable to update organisation reference in Staging Make error message to user clearer when updating an organisation identifier in Publisher Feb 13, 2024
@emmajclegg
Copy link
Collaborator

We will likely de-prioritise this issue, but will suggest some improvements to the user feedback received when a user enters an organisation identifier that does not match their Registry account (for future UI enhancements).

e.g. an error message along the lines of "Your organisation identifier must match the identifier linked to your IATI Registry publisher ID"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS
Projects
None yet
Development

No branches or pull requests

5 participants