Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox for (un-)checking alloptions in filter dropdown #43

Open
pschild opened this issue Oct 16, 2019 · 4 comments
Open

Checkbox for (un-)checking alloptions in filter dropdown #43

pschild opened this issue Oct 16, 2019 · 4 comments

Comments

@pschild
Copy link

pschild commented Oct 16, 2019

Hi guys!

The filter dropdown shows a list of all unique values, having a checkbox to be able to include or exclude the corresponding option in your filter (when using dropdownFilterShowOptionSelectCheckBox).
When you have a lot of options shown in that list, it would be awesome if we have a single checkbox to check (or uncheck) all visible options (maybe filtered when using dropdownFilterSearchable).

Is it possible to build this feature in?

Best regards,
pschild

@yohangz yohangz self-assigned this Oct 17, 2019
@yohangz
Copy link
Owner

yohangz commented Oct 17, 2019

Hi Pschild,

If you do not select any, by default it shows all the data without applying filtration hence, I don't see a value of adding a select all checkbox as it will become an overhead of explicitly triggering complex filter expressions to do the same thing.

Select all === do not apply filter === select none in Ornamentum

Also, you can use a clear button that comes handy to reset filtration.

Thanks,
Yohan

@yohangz yohangz closed this as completed Oct 17, 2019
@pschild
Copy link
Author

pschild commented Oct 18, 2019

Hi Yohan,

thanks for your feedback!
I get your point that "all checkboxes unchecked" equals "all checkboxes checked" and in this regard a "Check all/none" wouldn't make much sense. Nevertheless, in my current project I have a case where it definitely does.
Let me give you an example and explain my situation. I took the screenshots from Google Sheets, which offers this functionality:
example
1: I have a list of hundrets of zip codes.
2: I want to see all zip codes having "45" included, so I open the filter overlay and type in "45" into the search field. The list gets filtered by the given search term. Now I click "Select all" to check all filtered options. I click OK...
3: ...and see all zip codes containing "45".

If I would not have the possibility to "Select all", I would have had to select zip code by zip code separately, which possibly could mean a lot of clicks ;-) Additionally, using Text Box Filtering instead of Dropdown Filtering isn't an option for me in this case, in order to be as flexible as possible.

So I just want to make sure you got me right ;-) Maybe you give it another thought?

Cheers,
pschild

@yohangz
Copy link
Owner

yohangz commented Oct 23, 2019

Hi Pschild,

Great explanation. I will consider this as a feature request. However, I'm working on a major performance update + state management architecture change atm for v9.0.0.

Current feature priority:
https://github.com/yohangz/ornamentum/blob/master/docs/CHANGELOG.md#upcoming-features

Thanks,
Yohan

@yohangz yohangz reopened this Oct 23, 2019
@Calle-Lo
Copy link

Calle-Lo commented Apr 29, 2020

Nice I also need this feature! :)
When will this be implemented? Or will you never implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants