Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Linting & Refactor #1253

Open
1 task done
Talanor opened this issue May 12, 2024 · 3 comments
Open
1 task done

feat: Linting & Refactor #1253

Talanor opened this issue May 12, 2024 · 3 comments

Comments

@Talanor
Copy link
Contributor

Talanor commented May 12, 2024

Is there an existing feature or issue for this?

  • I have searched the existing issues

Expected feature

This is here for tracking purposes only.
I will try to track refactoring that needs to be made here.
A big pass of linting should be done at some point to homogenize code.
A lot of code duplication could be simplified (both in back and front)

Alternative solutions

No response

Anything else?

No response

Copy link

👋 Hi @Talanor,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@Talanor
Copy link
Contributor Author

Talanor commented May 12, 2024

Leverage django forms (form.is_valid()), widgets, viewforms, formsets and templates rather than hardcoding stuff:

Api Vault

  • web/scanEngine/views.py, api_vault, api_vault_delete
  • web/scanEngine/templates/scanEngine/settings/api.html

@Talanor
Copy link
Contributor Author

Talanor commented May 12, 2024

Use {% url %} django filter instead of hardcoded url paths & concatenation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant