Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing any errors if vscode typescript validation is disabled and eslint enabled #67

Closed
jpsantos7 opened this issue Jun 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jpsantos7
Copy link

jpsantos7 commented Jun 21, 2023

Describe the bug
If a setting as such is used:

{
  "typescript.validate.enable": false, // <- this is the setting
  "eslint.validate": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact"
  ]
}

no errors pretty-ts-errors are displayed. only the ESLint ones as shown in the following image:

Screenshot 2023-06-21 at 23 12 52

If we change this to true we now get all 3 validations: which is not desirable:

Screenshot 2023-06-21 at 23 12 31

Expected behavior
Being able to use the following setting and still be able to see the pretty errors and probably the eslint errors, but not the ts ones:

{
  "typescript.validate.enable": false
}
@jpsantos7 jpsantos7 added the bug Something isn't working label Jun 21, 2023
@uigywnkiub
Copy link

plx fix =)

@yoavbls
Copy link
Owner

yoavbls commented Jul 29, 2023

Hey @jpsantos7,
The extension can't work when the TypeScript validation is disabled because it uses that errors to generate the formatted ones. Unfortunately, until something changes in VSCode we can't hide the original messages, even though we want.
We're tacking it here: #3

And someone else asked about formatting eslint errors. I haven't seen a point in that since the errors are pretty simple and not containing complex types but I'm willing to consider it if I'll see a good example

@yoavbls yoavbls closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants