From a45dca84083be54fc488e9d1ba0831484682533b Mon Sep 17 00:00:00 2001 From: yko-git Date: Sun, 10 Mar 2024 13:45:18 +0900 Subject: [PATCH 01/21] fix 001_syntax/006_object --- 001_syntax/006_object.js | 1 - 1 file changed, 1 deletion(-) diff --git a/001_syntax/006_object.js b/001_syntax/006_object.js index 1ac6fff..26c1ee1 100644 --- a/001_syntax/006_object.js +++ b/001_syntax/006_object.js @@ -82,7 +82,6 @@ function isDuplicate(array) { for (let i = 0; i < array.length; i++) { //配列の要素をvalueに代入 const value = array[i]; - //objに配列要素があったら if (obj[value]) { return true; From 034b4f9f08e75364eba42f48e09fef1f6dca1595 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:03:52 +0900 Subject: [PATCH 02/21] fix 002_class/003_data filter --- 002_class/003_data.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/002_class/003_data.js b/002_class/003_data.js index 96869ff..f289c65 100644 --- a/002_class/003_data.js +++ b/002_class/003_data.js @@ -121,10 +121,12 @@ class List { */ filter(target) { // TODO: - let result = new List(this.data); - for (let i = 0; i <= result.length; i++) { - if (result[i] === target) { - result.splice(i, 1); + let result = new List(this.data); //Listインスタンスを作成 + //自身で作成したsizeを使用 + for (let i = 0; i <= result.size; i++) { + //自身で作成したindexを使用 + if (result.index(i) === target) { + result.remove(i); //自身で作成したremoveを使用 } } return result; From 87284e0592eea5e461237b9e3b6ea7c0998c2309 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:09:12 +0900 Subject: [PATCH 03/21] =?UTF-8?q?fix=20001=5Feasy=20length(length=E3=83=97?= =?UTF-8?q?=E3=83=AD=E3=83=91=E3=83=86=E3=82=A3=E3=82=92=E4=BD=BF=E7=94=A8?= =?UTF-8?q?=E3=81=97=E3=81=AA=E3=81=84=E3=83=91=E3=82=BF=E3=83=BC=E3=83=B3?= =?UTF-8?q?)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index 27567dd..806b405 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -12,7 +12,7 @@ function length(str) { let ans = 0; - for (let i = 1; i <= str.length; i++) { + for (let value of str) { ans++; } return ans; From 4e0d13493257da9c705fe66dcef3ad86791d64f7 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:21:51 +0900 Subject: [PATCH 04/21] =?UTF-8?q?fix=20001=5Feasy=20reverse(for=E3=82=92?= =?UTF-8?q?=E4=BD=BF=E7=94=A8=E3=81=97=E3=81=A6=E5=87=A6=E7=90=86=E3=82=92?= =?UTF-8?q?=E7=9F=AD=E3=81=8F=E3=80=81=E3=81=A7=E3=82=82join=E3=81=AF?= =?UTF-8?q?=E4=BD=BF=E3=81=A3=E3=81=A6=E3=81=97=E3=81=BE=E3=81=A3=E3=81=A6?= =?UTF-8?q?=E3=81=84=E3=82=8B)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index 806b405..7b51aef 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -30,8 +30,11 @@ function length(str) { * */ function reverse(str) { - let strArray = [...str]; - strArray.reverse(); + let strArray = []; + //後ろ側から取り出して並べる + for (let i = str.length - 1; i >= 0; i--) { + strArray.push(str[i]); + } return strArray.join(""); } From 73759ceb809374a3ebd05f42379fae6ccae26be0 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:25:27 +0900 Subject: [PATCH 05/21] =?UTF-8?q?fix=20001=5Feasy=20findIndex=20(for?= =?UTF-8?q?=E3=82=92=E4=BD=BF=E7=94=A8=E3=81=97=E3=81=A6=E3=82=B7=E3=83=B3?= =?UTF-8?q?=E3=83=97=E3=83=AB=E3=81=AB)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index 7b51aef..ca999b0 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -51,7 +51,12 @@ function reverse(str) { */ function findIndex(str, char) { - return str.indexOf(char); + for (let i = 0; i < str.length - 1; i++) { + if (str[i] === char) { + return i; + } + } + return -1; } /** From 72e8d0a1ff2327168758928914dde48bbcee948a Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:28:13 +0900 Subject: [PATCH 06/21] =?UTF-8?q?fix=20001=5Feasy=20average=20(return?= =?UTF-8?q?=E5=BE=8C=E3=81=AE=E4=B8=8D=E8=A6=81=E3=81=AAelse=E3=81=AE?= =?UTF-8?q?=E3=82=AB=E3=83=83=E3=82=B3=E3=82=92=E5=89=8A=E9=99=A4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index ca999b0..eec9902 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -111,13 +111,12 @@ function sum(array) { function average(array) { if (array.length === 0) { return 0; - } else { - const sum = array.reduce((pre, current) => { - return pre + current; - }, 0); - const average = sum / array.length; - return Math.floor(average); } + const sum = array.reduce((pre, current) => { + return pre + current; + }, 0); + const average = sum / array.length; + return Math.floor(average); } /** From e52ef3a389bc6fe189c1a2ceeef0851938cd7ccb Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:35:42 +0900 Subject: [PATCH 07/21] =?UTF-8?q?fix=20001=5Feasy=20concat=20(for=E6=96=87?= =?UTF-8?q?=E3=81=A7=E5=AE=9F=E8=A3=85=E3=81=97=E7=9B=B4=E3=81=97)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index eec9902..1b46dcb 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -132,7 +132,14 @@ function average(array) { */ function concat(a, b) { - return a.concat(b); + let result = []; + for (let i = 0; i <= a.length - 1; i++) { + result.push(a[i]); + } + for (let j = 0; j <= b.length - 1; j++) { + result.push(b[j]); + } + return result; } /** From 091cc245376c83872179a687670ec79572f0b8bc Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:38:33 +0900 Subject: [PATCH 08/21] =?UTF-8?q?fix=20001=5Feasy=20size=20(for=E6=96=87?= =?UTF-8?q?=E3=82=92=E4=BD=BF=E7=94=A8=E3=81=97=E3=81=A6=E5=AE=9F=E8=A3=85?= =?UTF-8?q?=E3=81=97=E7=9B=B4=E3=81=97)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index 1b46dcb..f696fb1 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -155,7 +155,11 @@ function concat(a, b) { */ function size(array) { - return array.length; + let ans = 0; + for (let value of array) { + ans++; + } + return ans; } /** From d727e15c79f195abffa5c89d423f84c30b09d0e6 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 10:42:25 +0900 Subject: [PATCH 09/21] =?UTF-8?q?fix=20001=5Feasy=20omitSeq=20(=E6=9C=80?= =?UTF-8?q?=E5=BE=8C=E3=81=ABfilter=E3=82=92=E4=BD=BF=E7=94=A8=E3=81=9B?= =?UTF-8?q?=E3=81=9A=E3=81=AB=E5=AE=9F=E8=A3=85=E3=81=97=E7=9B=B4=E3=81=97?= =?UTF-8?q?)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index f696fb1..f880da2 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -218,13 +218,13 @@ function seq(num) { */ function omitSeq(num) { - let ans = 0; + let ans = 1; let result = []; while (ans <= num) { result.push(ans); - ans += 1; + ans += 2; } - return result.filter((value) => value % 2 == 1); + return result; } /** From e91bd4c3fd5f8b968cd970eff00106d657d8fdbc Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 11:53:09 +0900 Subject: [PATCH 10/21] =?UTF-8?q?fix=20002=5Fmedium=20removeVowels=20(?= =?UTF-8?q?=E8=A4=87=E6=95=B0=E3=81=AE=E6=AF=94=E8=BC=83=E3=81=A0=E3=81=A8?= =?UTF-8?q?=E5=80=A4=E3=81=8C=E5=8F=96=E3=82=8C=E3=81=AA=E3=81=84)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 026b239..1e0833d 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -33,19 +33,21 @@ function rotate(str, num) { * */ function removeVowels(str) { - let strArray = [...str]; - strArray.forEach((value) => { + let newStr = ""; + + for (let i = 0; i < str.length; i++) { if ( - value === "a" || - value === "e" || - value === "i" || - value === "o" || - value === "u" + str[i] !== "a" || + str[i] !== "e" || + str[i] !== "i" || + str[i] !== "o" || + str[i] !== "u" ) { - strArray.splice(strArray.indexOf(value), 1, ""); + console.log(str[i]); + newStr += str[i]; } - }); - return strArray.join(""); + } + return newStr; } /** From 8ef3905331ae378da97b406a5a1ab9653c9b9664 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 11:59:37 +0900 Subject: [PATCH 11/21] =?UTF-8?q?fix=20002=5Fmedium=20isPalindrome=20(?= =?UTF-8?q?=E4=B8=8D=E8=A6=81=E3=81=AAif=E3=82=92=E5=89=8A=E9=99=A4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 1e0833d..6c7a5a9 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -43,7 +43,6 @@ function removeVowels(str) { str[i] !== "o" || str[i] !== "u" ) { - console.log(str[i]); newStr += str[i]; } } @@ -84,11 +83,7 @@ function isPalindrome(str) { const strArray = [...str]; const strReverse = [...str].reverse(); - if (strArray.toString() === strReverse.toString()) { - return true; - } else { - return false; - } + return strArray.toString() === strReverse.toString(); } /** From 94770796489ede8f269f6c5e8f536d59c4b48974 Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 12:14:18 +0900 Subject: [PATCH 12/21] =?UTF-8?q?fix=20002=5Fmedium=20isPalindrome=20(for?= =?UTF-8?q?=E6=96=87=E3=81=A7=E5=AE=9F=E8=A3=85=E3=81=97=E7=9B=B4=E3=81=97?= =?UTF-8?q?)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 6c7a5a9..fd4828b 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -80,10 +80,12 @@ function countStr(s1, s2) { */ function isPalindrome(str) { - const strArray = [...str]; - const strReverse = [...str].reverse(); - - return strArray.toString() === strReverse.toString(); + for (let i = 0; i < str.length; i++) { + if (str[i] !== str[str.length - 1 - i]) { + return false; + } + } + return true; } /** From 0c6e93d8b3245a959578acea539988c0209bd89c Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 13:28:21 +0900 Subject: [PATCH 13/21] =?UTF-8?q?fix=20002=5Fmedium=20isPrime=20(=E5=88=A5?= =?UTF-8?q?=E3=81=AE=E3=82=84=E3=82=8A=E6=96=B9=E3=81=A7=E5=AE=9F=E8=A3=85?= =?UTF-8?q?=E4=B8=AD=E3=81=A7=E3=81=99=E3=81=8C=E9=80=94=E4=B8=AD=E6=AE=B5?= =?UTF-8?q?=E9=9A=8E)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index fd4828b..1f27852 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -103,13 +103,19 @@ function isPalindrome(str) { * */ function isPrime(num) { - if (num === 2 || num === 3) { - return true; - } else if (num === 1 || num % 2 === 0 || num % 3 === 0) { - return false; - } else { - return true; + //numが2桁以上の場合 + if (num.length >= 2) { + num = Array.from(String(num), Number); + for (let i = 0; i < num.length; i++) { + num = num[i] + num[i + 1]; + } + } + for (let i = 0; i <= num; i++) { + if (num % i === 0 || num === 1 || num === 2) { + return false; + } } + return true; } /** From aec1f4a956a3565b6c646160a4edca768a3be3db Mon Sep 17 00:00:00 2001 From: yko-git Date: Fri, 15 Mar 2024 16:19:54 +0900 Subject: [PATCH 14/21] =?UTF-8?q?002=5Fmedium=20sumWithout4andNext=20(?= =?UTF-8?q?=E5=89=8D=E3=81=AE=E8=A6=81=E7=B4=A0=E3=82=92=E8=B5=B7=E7=82=B9?= =?UTF-8?q?=E3=81=AB=E6=9B=B8=E3=81=8D=E7=9B=B4=E3=81=97)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 1f27852..375477a 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -134,32 +134,15 @@ function isPrime(num) { * */ function sumWithout4andNext(array) { - //空の配列をsumArrayを定義 - let sumArray = []; + let total = 0; - //array分ループを回す for (let i = 0; i < array.length; i++) { - //array[1]が4だったら - if (array[i] === 4) { - //sumArrayに0をpush - sumArray.push(0); - - //次の要素も4だった場合 - if (array[i + 1] === 4) { - //次の要素も0にする - array[i] = 0; - } else { - array[i + 1] = 0; - } - } else { - sumArray.push(array[i]); + if (array[i - 1] !== 4 && array[i] !== 4) { + total += array[i]; } } - const sum = sumArray.reduce((pre, current) => { - return pre + current; - }); - return sum; + return total; } module.exports = { From c70dcc26eb60163a7415f6adea513293ab6c5fa6 Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 06:48:01 +0900 Subject: [PATCH 15/21] =?UTF-8?q?fix=20001=5Feasy=20length(while=E3=81=AE?= =?UTF-8?q?=E6=9B=B8=E3=81=8D=E6=96=B9=E3=81=AB=E5=A4=89=E6=9B=B4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index f880da2..acbbda6 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -12,7 +12,7 @@ function length(str) { let ans = 0; - for (let value of str) { + while (str[ans]) { ans++; } return ans; From f1a8bbc9ee630c15355bc408f069f2e5c73bd6ce Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 06:48:53 +0900 Subject: [PATCH 16/21] =?UTF-8?q?fix=20001=5Feasy=20reverse(=E9=85=8D?= =?UTF-8?q?=E5=88=97=E3=81=AB=E5=A4=89=E6=8F=9B=E3=81=9B=E3=81=9Astring?= =?UTF-8?q?=E3=81=AE=E3=81=BE=E3=81=BE=E3=81=AB=E5=A4=89=E6=9B=B4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index acbbda6..f1a34d0 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -30,12 +30,12 @@ function length(str) { * */ function reverse(str) { - let strArray = []; + let newStr = ""; //後ろ側から取り出して並べる for (let i = str.length - 1; i >= 0; i--) { - strArray.push(str[i]); + newStr += str[i]; } - return strArray.join(""); + return newStr; } /** From 50786f3370c8c4750c13cde834e49e4ff8a7f01a Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 10:42:34 +0900 Subject: [PATCH 17/21] =?UTF-8?q?fix=20001=5Feasy=20average(for=E6=96=87?= =?UTF-8?q?=E3=81=A7=E6=9B=B8=E3=81=8D=E6=8F=9B=E3=81=88)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index f1a34d0..66a5627 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -112,11 +112,12 @@ function average(array) { if (array.length === 0) { return 0; } - const sum = array.reduce((pre, current) => { - return pre + current; - }, 0); - const average = sum / array.length; - return Math.floor(average); + + let average = 0; + for (let i = 0; i < array.length; i++) { + average += array[i]; + } + return Math.floor(average / array.length); } /** From ea3c39eb89f496ce28d94eb0d92e7592b2544999 Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 10:47:53 +0900 Subject: [PATCH 18/21] =?UTF-8?q?fix=20001=5Feasy=20concat=20(=E3=82=B9?= =?UTF-8?q?=E3=83=97=E3=83=AC=E3=83=83=E3=83=89=E6=A7=8B=E6=96=87=E3=81=A7?= =?UTF-8?q?=E6=9B=B8=E3=81=8D=E7=9B=B4=E3=81=97)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/001_easy.js | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/003_practice/001_easy.js b/003_practice/001_easy.js index 66a5627..99fed97 100644 --- a/003_practice/001_easy.js +++ b/003_practice/001_easy.js @@ -133,14 +133,7 @@ function average(array) { */ function concat(a, b) { - let result = []; - for (let i = 0; i <= a.length - 1; i++) { - result.push(a[i]); - } - for (let j = 0; j <= b.length - 1; j++) { - result.push(b[j]); - } - return result; + return [...a, ...b]; } /** From 3d31071faba6333a1afb9ce0aba000482708c347 Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 10:51:11 +0900 Subject: [PATCH 19/21] =?UTF-8?q?fix=20002=5Fmedium=20isPalindrome=20(?= =?UTF-8?q?=E9=85=8D=E5=88=97=E3=82=92=E5=8D=8A=E5=88=86=E5=9B=9E=E3=81=99?= =?UTF-8?q?=E5=87=A6=E7=90=86=E3=81=AB=E5=A4=89=E6=9B=B4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 375477a..9ff7e44 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -80,7 +80,7 @@ function countStr(s1, s2) { */ function isPalindrome(str) { - for (let i = 0; i < str.length; i++) { + for (let i = 0; i < str.length / 2; i++) { if (str[i] !== str[str.length - 1 - i]) { return false; } From 09d4a966abfccd68fe4f47a1260c56c6b8ccaae5 Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 10:59:07 +0900 Subject: [PATCH 20/21] =?UTF-8?q?fix=20002=5Fmedium=20removeVowels=20(?= =?UTF-8?q?=E8=AB=96=E7=90=86=E6=BC=94=E7=AE=97=E5=AD=90=E3=82=92=E5=A4=89?= =?UTF-8?q?=E6=9B=B4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index 9ff7e44..d1a77ae 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -37,10 +37,10 @@ function removeVowels(str) { for (let i = 0; i < str.length; i++) { if ( - str[i] !== "a" || - str[i] !== "e" || - str[i] !== "i" || - str[i] !== "o" || + str[i] !== "a" && + str[i] !== "e" && + str[i] !== "i" && + str[i] !== "o" && str[i] !== "u" ) { newStr += str[i]; From 5d3961fc0cdbc0161c02b296a2f9d9f910253f14 Mon Sep 17 00:00:00 2001 From: yko-git Date: Sat, 16 Mar 2024 14:14:46 +0900 Subject: [PATCH 21/21] =?UTF-8?q?fix=20002=5Fmedium=20isPrime=20(for?= =?UTF-8?q?=E3=81=A7=E6=9B=B8=E3=81=8D=E7=9B=B4=E3=81=97)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 003_practice/002_medium.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/003_practice/002_medium.js b/003_practice/002_medium.js index d1a77ae..c75df76 100644 --- a/003_practice/002_medium.js +++ b/003_practice/002_medium.js @@ -103,15 +103,12 @@ function isPalindrome(str) { * */ function isPrime(num) { - //numが2桁以上の場合 - if (num.length >= 2) { - num = Array.from(String(num), Number); - for (let i = 0; i < num.length; i++) { - num = num[i] + num[i + 1]; - } + //numが2の場合 + if (num === 1) { + return false; } - for (let i = 0; i <= num; i++) { - if (num % i === 0 || num === 1 || num === 2) { + for (let i = 2; i < num; i++) { + if (num % i === 0) { return false; } }