Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner don't render error body if throw exception after ob_start() #55

Open
vjik opened this issue Jul 11, 2023 · 0 comments
Open

Runner don't render error body if throw exception after ob_start() #55

vjik opened this issue Jul 11, 2023 · 0 comments
Labels

Comments

@vjik
Copy link
Member

vjik commented Jul 11, 2023

In runner:

 try {
    // ...
    // Here response stream: `ob_start(); throw Exception()`
    $this->emit($request, $response);
} catch (Throwable $throwable) {
    $handler = new ThrowableHandler($throwable);
    /**
     * @var ResponseInterface
     * @psalm-suppress MixedMethodCall
     */
    $response = $container
        ->get(ErrorCatcher::class)
        ->process($request, $handler);
    $this->emit($request, $response);
}
@samdark samdark added the type:bug Bug label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants