New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming issue: attribute #583

Open

samdark opened this issue Feb 22, 2023 · 1 comment

Labels

severity:BC breaking type:task

Milestone

Member

samdark commented Feb 22, 2023 •

edited

We call data properties "attributes" because in both Yii1 and Yii2 these were called so. The issue is that PHP now has https://www.php.net/manual/en/language.attributes.overview.php so the name became very confusing.

Renaming would require breaking BC so that's for the next major version.

Thanks, @vudaltsov for pointing it.

samdark added the type:bug label

samdark added this to the 2.0.0 milestone

arogachev added type:task severity:BC breaking and removed type:bug labels

Contributor

arogachev commented Feb 23, 2023

I used "attributes" / "PHP attributes", but agree that the naming can be improved.

vjik mentioned this issue

Naming issue: attribute yiisoft/form#267

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment