Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Inflector #108

Open
xepozz opened this issue Aug 12, 2023 · 3 comments
Open

Optimize Inflector #108

xepozz opened this issue Aug 12, 2023 · 3 comments

Comments

@xepozz
Copy link
Contributor

xepozz commented Aug 12, 2023

We have introduced https://github.com/yiisoft/strings/blob/master/src/CombinedRegexp.php that helps with a loop of regexps.
There are some places to apply CombinedRegexp:

@vjik vjik added type:enhancement Enhancement status:ready for adoption Feel free to implement this issue. labels Aug 12, 2023
@vjik
Copy link
Member

vjik commented Oct 23, 2023

User can override rules via withSingularizeRules() and withPluralizeRules() methods, and use regular expressions with different flags. It is do not allow us use CombinedRegexp here.

@vjik vjik added status:under discussion and removed status:ready for adoption Feel free to implement this issue. labels Oct 23, 2023
@xepozz
Copy link
Contributor Author

xepozz commented Oct 23, 2023

I didn't get you

@vjik
Copy link
Member

vjik commented Oct 23, 2023

I didn't get you

CombinedRegexp uses same flags for all expressions, but inflector allow use expressions with different flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants