Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code implementation does not match the original paper #22

Open
WANGBohaO-jpg opened this issue Jun 18, 2023 · 2 comments
Open

The code implementation does not match the original paper #22

WANGBohaO-jpg opened this issue Jun 18, 2023 · 2 comments

Comments

@WANGBohaO-jpg
Copy link

The function _sample_negative in data.py appears to be incorrect. It currently utilizes ratings to generate negative samples, resulting in the exclusion of test items for each user from the negative samples. But the test items should be treated as negative samples in training set.

@yihong-chen
Copy link
Owner

@WANGBohaO-jpg Thanks for pointing out this. Would you like to create a pull request to fix the issue?

@patelrajnath
Copy link

patelrajnath commented May 3, 2024

@yihong-chen I created a full request, which is able to produce comparable results to the one reported in the paper. Have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants