Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add body to response.request #208

Open
bernd-wechner opened this issue Jan 4, 2024 · 1 comment
Open

[Feature] Add body to response.request #208

bernd-wechner opened this issue Jan 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bernd-wechner
Copy link

Is your feature request related to a problem? Please describe.
Just a compatibility problem with the existing requests package in Python. If we POST a request then the response has a request object as an attribute and being a POST, that request object has a body attribute (being the posted data). I love this package, thanks enormously! This would help it slot in as a simple replacement for request, but may of course be one of many compatibility issues in the end. Just one I found when I swapped to this package in an existing script that POSTs and checks response.request.body.

Describe the solution you'd like
That the request recorded against a response contain all the request attributes ...

Describe alternatives you've considered
I just take it from the request I sent ;-)

@bernd-wechner bernd-wechner added the enhancement New feature or request label Jan 4, 2024
@yifeikong
Copy link
Owner

If requests has it, we should add it. In the meanwhile, you need to keep a reference to the body variable by yourself.

@yifeikong yifeikong added the good first issue Good for newcomers label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants