Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is BitcoinAddress legacy wrong when HashType is .scriptHash ? #273

Open
QiuDaniel opened this issue Jan 6, 2022 · 0 comments
Open

Is BitcoinAddress legacy wrong when HashType is .scriptHash ? #273

QiuDaniel opened this issue Jan 6, 2022 · 0 comments

Comments

@QiuDaniel
Copy link

QiuDaniel commented Jan 6, 2022 •
edited

In BitcoinAddress+Legacy.swift
public var legacy: String {
switch hashType {
case .pubkeyHash:
return Base58Check.encode([network.pubkeyhash] + data)
case .scriptHash:
return Base58Check.encode([network.pubkeyhash] + data)
}
}

correct way:
case .scriptHash:
return Base58Check.encode([network.scripthash] + data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QiuDaniel