Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EO violation in Wire? #70

Open
fabriciofx opened this issue Jan 19, 2019 · 4 comments
Open

EO violation in Wire? #70

fabriciofx opened this issue Jan 19, 2019 · 4 comments

Comments

@fabriciofx
Copy link

fabriciofx commented Jan 19, 2019

Into the Wire interface we have a method Input send(Input input) throws IOException, but it isn't a EO violation? In EO vol 1, Yegor says "verb methods should return nothing (void)" and send() is a verb. So, should we rename it? My suggestion: Input response(Input request) throws IOException.

@0crat
Copy link
Collaborator

0crat commented Jan 19, 2019

@llorllale/z please, pay attention to this issue

@llorllale
Copy link
Collaborator

@fabriciofx fair enough, but neither solutions are correct according to Yegor's book.

@fabriciofx
Copy link
Author

@llorllale why not?

@fabriciofx
Copy link
Author

fabriciofx commented Jul 16, 2019

@llorllale WDYT:

interface Request extends Input {
}

interface Response extends Input {
}

Response response(Request req) throws Exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants