-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EO violation in Wire? #70
Comments
@llorllale/z please, pay attention to this issue |
@fabriciofx fair enough, but neither solutions are correct according to Yegor's book. |
@llorllale why not? |
@llorllale WDYT:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Into the
Wire
interface we have a methodInput send(Input input) throws IOException
, but it isn't a EO violation? In EO vol 1, Yegor says "verb methods should return nothing (void)" andsend()
is a verb. So, should we rename it? My suggestion:Input response(Input request) throws IOException
.The text was updated successfully, but these errors were encountered: