Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listeners before sign out, not after #68

Open
richford opened this issue Sep 21, 2023 · 2 comments
Open

Remove listeners before sign out, not after #68

richford opened this issue Sep 21, 2023 · 2 comments
Assignees

Comments

@richford
Copy link
Contributor

Sentry reports this error: https://roar-89588e380.sentry.io/issues/4494114498/events/fd5f47796f02436481ddeebb16f52560/

This is happening after the user signs out, so it's not really a bug per se. But it revealed to me that we should unsubscribe from our listeners before signing out, not after.

That amounts to moving this line through this line into this function and moving this line through this line into this function.

I think this should eliminate the error.

@richford
Copy link
Contributor Author

Be sure to add fixes LETTER-5 in the commit message for this fix. It will automatically close the Sentry issue.

@sentry-io
Copy link

sentry-io bot commented Sep 21, 2023

Sentry issue: LETTER-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants