Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for game image resizing issues #140

Closed
wants to merge 1 commit into from
Closed

Conversation

dguimara
Copy link

A few changes to fix the image resizing/cropping problem for game images.

@dguimara dguimara linked an issue Sep 21, 2023 that may be closed by this pull request
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit c695841):

https://gse-roar-admin--pr140-hotfix-gamecard-imag-2d027r8d.web.app

(expires Thu, 28 Sep 2023 22:28:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3c54708fa308bfea9142d27be42e0ed92f5c360d

@jyeatman
Copy link
Member

As far as I can tell this fixed the issue (though the games in my admin were old). Taggine @richford to review and merge

@richford
Copy link
Contributor

@dguimara, I tested this with username carrie-test-lab (same password). Your fix is good for smaller screens, however, the size is still variable for larger screens.

@richford richford closed this Jan 25, 2024
@richford richford deleted the hotfix/gamecard-images branch May 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep original image size in game tabs
4 participants