Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to CI for Vyper files #16

Open
chriswessels opened this issue Oct 14, 2020 · 16 comments
Open

Add linting to CI for Vyper files #16

chriswessels opened this issue Oct 14, 2020 · 16 comments
Labels
bounty enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time

Comments

@chriswessels
Copy link
Contributor

Currently have linting for Python and Solidity files, but not Vyper.

Add linting support + hook up to Github workflows.

@fubuloubu
Copy link
Member

fubuloubu commented Oct 14, 2020

Note: a tool doesn't exist for this yet, but it is possible to make one using Vyper's public API (which can output the AST)

@milkyklim milkyklim added this to To do in Development via automation Oct 21, 2020
@milkyklim milkyklim added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2020
@spinoch
Copy link

spinoch commented Oct 28, 2020

I'm looking into creating such a tool. Is there any chance for compensation in case it resolves this issue? (Not asking for specific numbers, but would be nice to get something)

@fubuloubu
Copy link
Member

@spinoch yes! I think I can find some individuals that can put together a bounty if you are willing to help take this on!

@spinoch
Copy link

spinoch commented Oct 29, 2020

Cool. I'll see if I can come up with something by next week

@saltyfacu saltyfacu added this to Low priority in Vaults & Strategies Feb 2, 2021
@saltyfacu saltyfacu added the p3 Fix if time label Feb 4, 2021
@saltyfacu saltyfacu moved this from Backlog to In progress in Vaults & Strategies Feb 6, 2021
@saltyfacu
Copy link

Hey @spinoch! It seems that you've done a lot of progress in the PR. Are you still working on it?

@spinoch
Copy link

spinoch commented Mar 2, 2021

Hey, @fameal . In short, no. We need to fix a few issues in the blackadder repo and I haven't had time lately. I still would like to get the issues fixed but I can't really give a time frame atm

@0xbeedao
Copy link

I have submitted a PR to fix this outstanding issue. #479

@pandadefi
Copy link
Contributor

We need someone to build and maintain a linter. The linter should be able to work with multiple versions of vyper

@fubuloubu
Copy link
Member

We need someone to build and maintain a linter. The linter should be able to work with multiple versions of vyper

note that @spinoch made a first cut of it here: https://github.com/vyperlang/blackadder

@AbnerZheng
Copy link

@fubuloubu I would like try to finish the remaining work. I have looked through the PR(#52), the remaining work is to (correctly) reformat code for mutability of the method, am I right?

@fubuloubu
Copy link
Member

@fubuloubu I would like try to finish the remaining work. I have looked through the PR(#52), the remaining work is to (correctly) reformat code for mutability of the method, am I right?

No, there is updates needed to the tool for it to work

@AbnerZheng
Copy link

@fubuloubu Yeah, I have checked the tool(https://github.com/vyperlang/blackadder), currently it is simply based on regexp, should I modified it according to the AST to make a normal formatter? Or maybe fork the black(https://github.com/psf/black), and modified the code according to the grammar rule of Vyper?

@fubuloubu
Copy link
Member

@fubuloubu Yeah, I have checked the tool(https://github.com/vyperlang/blackadder), currently it is simply based on regexp, should I modified it according to the AST to make a normal formatter? Or maybe fork the black(https://github.com/psf/black), and modified the code according to the grammar rule of Vyper?

Will accept PRs to that repo, yes

@AbnerZheng
Copy link

Cool, I will try it.

@dbale-altoros
Copy link

Is there any advance in creating a linter for vyper ?

@fubuloubu
Copy link
Member

actually yeah, https://github.com/vyperlang/mamushi got a little further in terms of what it can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time
Projects
Development
  
To do
Development

Successfully merging a pull request may close this issue.

9 participants