[RFC] Make all subcommands async #4176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
force-pushed
the
async-commands
branch
4 times, most recently
from
f83bc36
to
6b8c800
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4176 +/- ##
==========================================
- Coverage 88.82% 79.04% -9.79%
==========================================
Files 34 29 -5
Lines 4395 2730 -1665
==========================================
- Hits 3904 2158 -1746
- Misses 491 572 +81 |
bstaletic
force-pushed
the
async-commands
branch
from
6b8c800
to
0a7c427
Compare
|
Gitter chat concluded that this should not be done as naively as in this pull request. The problem is that this pull request provides no way of cancelling a request. In case of really slow ops, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
Fixes #4112
This change is