Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing quality resets video position #371

Closed
1 task done
Insprill opened this issue Dec 9, 2022 · 4 comments · Fixed by #651
Closed
1 task done

Changing quality resets video position #371

Insprill opened this issue Dec 9, 2022 · 4 comments · Fixed by #651
Assignees
@stonerl
Labels
bug Something isn't working

Comments

@Insprill
Copy link

Insprill commented Dec 9, 2022

Guidelines

  • I have searched the issue tracker and I haven't found bug report like this

Current Behavior

Changing a video's quality will reset you back to the beginning, or its last saved location.

Expected Behavior

When you change the video quality, it should resume from where it was before the change.

Device & OS Version

iPhone 8+, IOS 16.1.2

App Build

1.4.2 build 112

App Settings

No response

Crash log

No response

Screenshots, Videos and other files

It's a little hard to see as text is in the way, but I was about 5:40 into the video, changed the quality, and went right back to the beginning.

RPReplay_Final1670618352.mov
@Insprill Insprill added the bug Something isn't working label Dec 9, 2022
@Insprill Insprill mentioned this issue May 10, 2023
Closed
1 task
@stonerl
Copy link
Collaborator

stonerl commented Apr 25, 2024

@Insprill Doesn't happen with the latest build (181). Can you test this?

@Insprill
Copy link
Author

The latest version on the app store is 174, so I can't test it until it release.

@stonerl
Copy link
Collaborator

stonerl commented Apr 25, 2024

If you like, you could install the latest build via TestFlight. Instructions are here.

stonerl added a commit to stonerl/yattee that referenced this issue May 1, 2024
@stonerl
preserve time on stream change
0d5a907 
fixes yattee#371
@stonerl stonerl mentioned this issue May 1, 2024
Merged
@stonerl
Copy link
Collaborator

stonerl commented May 1, 2024

Was still an issue with the latest build. I made a PR to fix the issue.

@stonerl stonerl self-assigned this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonerl stonerl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preserve time on stream change stonerl/yattee
2 participants
@stonerl @Insprill