Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captions show when disabled #490

Closed
1 task done
bbsixzz opened this issue Jun 8, 2023 · 2 comments · Fixed by #636
Closed
1 task done

Captions show when disabled #490

bbsixzz opened this issue Jun 8, 2023 · 2 comments · Fixed by #636
Assignees
@stonerl
Labels
bug Something isn't working

Comments

@bbsixzz
Copy link

bbsixzz commented Jun 8, 2023

Guidelines

  • I have searched the issue tracker and I haven't found bug report like this

Current Behavior

RPReplay_Final1686203379.mp4

Expected Behavior

To not show.

Device & OS Version

iOS 16.5

App Build

153

App Settings

No response

Crash log

No response

Screenshots, Videos and other files

No response
@bbsixzz bbsixzz added the bug Something isn't working label Jun 8, 2023
@Umpaaa
Copy link

Umpaaa commented Jul 23, 2023

Same issue. Hitting "disabled" again does turn them off for the current video though just fyi

@ooosssay
Copy link
Contributor

Same issue with me and yes disabling again does temporarily fixes the issue.

stonerl added a commit to stonerl/yattee that referenced this issue Apr 20, 2024
@stonerl
fix handling and displaying captions
b0cfdea 
fixes yattee#490

It also fixes the caption picker being empty when a caption was selected in the previous watched video.
@stonerl stonerl mentioned this issue Apr 20, 2024
Merged
stonerl added a commit to stonerl/yattee that referenced this issue Apr 20, 2024
@stonerl
fix handling and displaying captions
f3637e2 
fixes yattee#490

It also fixes the caption picker being empty when a caption was selected in the previous watched video.
@stonerl stonerl self-assigned this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonerl stonerl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix handling and displaying captions stonerl/yattee
4 participants
@stonerl @bbsixzz @Umpaaa @ooosssay