Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video not scrubbing #626

Closed
1 task done
ooosssay opened this issue Mar 5, 2024 · 6 comments · Fixed by #662
Closed
1 task done

Video not scrubbing #626

ooosssay opened this issue Mar 5, 2024 · 6 comments · Fixed by #662
Assignees
Labels
bug Something isn't working Piped

Comments

@ooosssay
Copy link
Contributor

ooosssay commented Mar 5, 2024

Guidelines

  • I have searched the issue tracker and I haven't found bug report like this

Current Behavior

When scrubbing it does nothing at all and the video just continues to play.

Expected Behavior

To go to the time I scrubbed to.

Device & OS Version

iPhone, iOS 17.2.1

App Build

180

App Settings

No response

Crash log

No response

Screenshots, Videos and other files

yattee-180-mpv-log.txt

RPReplay_Final1709599844.mov
@ooosssay ooosssay added the bug Something isn't working label Mar 5, 2024
@stonerl
Copy link
Collaborator

stonerl commented Apr 1, 2024

I noticed this as well. But it only seems to happen with Piped. Not with Invidious, though.

@stonerl stonerl added the Piped label Apr 1, 2024
@ooosssay
Copy link
Contributor Author

ooosssay commented Apr 1, 2024

This is true as when I was recording the video I was using a piped instance.

@stonerl
Copy link
Collaborator

stonerl commented Apr 26, 2024

@ooosssay Can you switch to a different codec? I think the problem only appears is with mp4.

stonerl added a commit to stonerl/yattee that referenced this issue Apr 26, 2024
Currently, mp4 is one of the first formats chosen. But there are some issues when it comes to scrubbing/seeking. Therefore we only use mp4 as the last resort, this should give a better user experience.

sort of fixes yattee#590 & yattee#626 & yattee#487

Also when choosing the AVPlayer in the Quality settings, disabled formats are hidden.
@ooosssay
Copy link
Contributor Author

While I was testing this, stream was working fine but when I tried the other codecs they will stop loading when at a new timestamp or freeze the frame with audio still playing (might be the server)

@stonerl
Copy link
Collaborator

stonerl commented Apr 26, 2024

Yeah, it is better when using WebM over MP4 it seems, but still has some issues. Especially when scrubbing too far outside the current buffer.

HLS or Stream is the way to go. I'll try to implement the missing features like captions and playback speed in AVPlayer, since it supports HLS and HLS is preferable over Stream IMHO.

@stonerl
Copy link
Collaborator

stonerl commented May 3, 2024

Did some digging. The problem is unrelated to the codec used. It seems more an issue with Piped. When scrubbing or jumping forward, Yattee requests new segments of the video, and it seems it that requesting these segments takes up a long time. Every so often, one has to wait up to a minute for the correct segment to be found. Then the playback continues.

stonerl added a commit to stonerl/yattee that referenced this issue May 3, 2024
Currently, mp4 is one of the first formats chosen. But there are some issues when it comes to scrubbing/seeking. Therefore we only use mp4 as the last resort, this should give a better user experience.

sort of fixes yattee#590 & yattee#626 & yattee#487

Also when choosing the AVPlayer in the Quality settings, disabled formats are hidden.

first step to make formats sortable

hls and stream are now comparable formats

better naming for streams

move bestPlayable to PlayerBackend

Revert "move bestPlayable to PlayerBackend"

This reverts commit 7daf7fcf36cbf1b0001c18a657220777643d354a.

Reapply "move bestPlayable to PlayerBackend"

This reverts commit dd129fe5a96cc8d7cab3371aec9e8f9bfb65cfa2.

changing to wording

some finetuning
stonerl added a commit to stonerl/yattee that referenced this issue May 9, 2024
By default all videos on Piped are proxied via the instance. This comes with severe playback issues. Allowing the user to not proxy the videos should give a better playback experience.

This should fix a bunch of playback issues: yattee#626, yattee#590, yattee#585, yattee#498, yattee#400
stonerl added a commit to stonerl/yattee that referenced this issue May 16, 2024
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.

This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.

Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.

This should fix numerous playback issues: yattee#666, yattee#626, yattee#590, yattee#585, yattee#498, yattee#457, yattee#400
stonerl added a commit to stonerl/yattee that referenced this issue May 16, 2024
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.

This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.

Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.

This should fix numerous playback issues: yattee#666, yattee#626, yattee#590, yattee#585, yattee#498, yattee#457, yattee#400
stonerl added a commit to stonerl/yattee that referenced this issue May 17, 2024
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.

This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.

Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.

This should fix numerous playback issues: yattee#666, yattee#626, yattee#590, yattee#585, yattee#498, yattee#457, yattee#400
stonerl added a commit to stonerl/yattee that referenced this issue May 17, 2024
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.

This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.

Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.

This should fix numerous playback issues: yattee#666, yattee#626, yattee#590, yattee#585, yattee#498, yattee#457, yattee#400
stonerl added a commit to stonerl/yattee that referenced this issue May 17, 2024
I added a new feature. When instances are not proxied, Yattee first checks the URL to make sure it is not a restricted video. Usually, music videos and sports content can only be played back by the same IP address that requested the URL in the first place. That is why some videos do not play when the proxy is disabled.

This approach has multiple advantages. First and foremost, It reduced the load on Invidious/Piped instances, since users can now directly access the videos without going through the instance, which might be severely bandwidth limited. Secondly, users don't need to manually turn on the proxy when they want to watch IP address bound content, since Yattee automatically proxies such content.

Furthermore, adding the proxy option allows mitigating some severe playback issues with invidious instances. Invidious by default returns proxied URLs for videos, and due to some bug in the Invidious proxy, scrubbing or continuing playback at a random timestamp can lead to severe wait times for the users.

This should fix numerous playback issues: yattee#666, yattee#626, yattee#590, yattee#585, yattee#498, yattee#457, yattee#400
@stonerl stonerl linked a pull request May 18, 2024 that will close this issue
@stonerl stonerl self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Piped
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants