[WIP] Add playlist pagination support #615
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifo9
force-pushed
the
jf/playlist-pagination
branch
from
f7fdb88
to
73b4ac8
Compare
lifo9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #586.
Adds support for playlist pagination.
Invidious
Invidious API does not provide pagination data, only
videoCountparameter in response.Moreover, I've found that it contains duplicities (probably a bug?).
Thus, we can only try to fetch the next page, check if there are any videos present and if so, filter out duplicites.
PeerTube
It uses count and start query parameters to set number of returned items and offset used to paginate the result.
It also returns
total- number of videos in playlist.Piped
Piped API uses nextpage query parameter for playlist pagination.