Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units for maxDownloadSize are not defined in docs/comments #460

Open
Original-Carl opened this issue Mar 30, 2021 · 0 comments
Open

Units for maxDownloadSize are not defined in docs/comments #460

Original-Carl opened this issue Mar 30, 2021 · 0 comments

Comments

@Original-Carl
Copy link

https://github.com/yasserg/crawler4j/blob/master/crawler4j/src/main/java/edu/uci/ics/crawler4j/crawler/CrawlConfig.java, Lines 122-126.

A note in the javadoc stating "bytes" or "kilobytes" or whatever would really help. Presently, crawler4J warns me pages are exceeding the maxDownloadSize on pages that appear to be more than 8MB but not on pages with less than 7.5MB.

Just trying to figure this all out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant