Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better offline detection #8097

Closed
PutziSan opened this issue May 4, 2020 · 1 comment
Closed

Better offline detection #8097

PutziSan opened this issue May 4, 2020 · 1 comment
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.

Comments

@PutziSan
Copy link

PutziSan commented May 4, 2020

I follow #4890 for over 2 years now and it ist really fun and all.
But for real, I think 9/10 of these issues would disappear, If you would not use a timeout for downloading large packages, but try to verify if the User is offline or just on a slow network (maybe a 1kb-test ping could do the trick?).
If he is on a slow network, do not try to restart the download, but keep it open and wait.
Would that be possible or am I on the wrong track?

@merceyz
Copy link
Member

merceyz commented Jan 2, 2021

Closing as fixed in v2 where the timeout logic is less susceptible to this sort of issue

https://yarnpkg.com/getting-started/migration

@merceyz merceyz closed this as completed Jan 2, 2021
@merceyz merceyz added the fixed-in-modern This issue has been fixed / implemented in Yarn 2+. label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.
Projects
None yet
Development

No branches or pull requests

2 participants