Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: silent mode through --silent not working with yarn run #4383

Closed
BYK opened this issue Sep 10, 2017 · 2 comments
Closed

Bug: silent mode through --silent not working with yarn run #4383

BYK opened this issue Sep 10, 2017 · 2 comments
Assignees
@BYK
Labels
cat-bug

Comments

@BYK
Copy link
Member

BYK commented Sep 10, 2017

#788 added a --silent mode for yarn run but it is not working anymore after 1.0

Culprit: #4152.
@BYK BYK added the cat-bug label Sep 10, 2017
@BYK BYK mentioned this issue Sep 10, 2017
Closed
@BYK BYK self-assigned this Sep 10, 2017
BYK added a commit that referenced this issue Sep 10, 2017
@BYK
Fix: fix incorrect argument parsing
5feff12 
**Summary**

Fixes #4383. This patch makes argument parsing a bit tidier, and
starts supporting `yarn --silent custom-script` style commands as
initiall intended by #4152.

**Test plan**

Existing unit tests.
@BYK BYK mentioned this issue Sep 10, 2017
Merged
@BYK BYK closed this as completed in #4384 Sep 12, 2017
BYK added a commit that referenced this issue Sep 12, 2017
@BYK
Fix: fix incorrect argument parsing (#4384)
cb3c7fe 
**Summary**

Fixes #4383. This patch makes argument parsing a bit tidier, and
starts supporting `yarn --silent custom-script` style commands as
initiall intended by #4152.

**Test plan**

Existing unit tests. Should ideally add a few more.
joaolucasl pushed a commit to joaolucasl/yarn that referenced this issue Oct 27, 2017
@BYK @joaolucasl
Fix: fix incorrect argument parsing (yarnpkg#4384)
2a809c6 
**Summary**

Fixes yarnpkg#4383. This patch makes argument parsing a bit tidier, and
starts supporting `yarn --silent custom-script` style commands as
initiall intended by yarnpkg#4152.

**Test plan**

Existing unit tests. Should ideally add a few more.
@alexraileanu
Copy link

@BYK this is still happening in 1.3.2. adding --silent doesn't do anything. do you have any updates regarding this?

@BYK
Copy link
Member Author

BYK commented Dec 7, 2017

@alexraileanu please file a new issue with the details since as far as this particular issue is concerned, it is fixed. Yours is probably different and we need all the details around it to be able to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BYK BYK

Labels
cat-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BYK @alexraileanu