Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn should make better use of dist-tags #4208

Open
ewingrj opened this issue Aug 18, 2017 · 3 comments
Open

Yarn should make better use of dist-tags #4208

ewingrj opened this issue Aug 18, 2017 · 3 comments

Comments

@ewingrj
Copy link

ewingrj commented Aug 18, 2017

Do you want to request a feature or report a bug?
bug

What is the current behavior?
when installing web3-core yarn is resolving the lerna-temp tag, but should be resolving the latest tag.

If the current behavior is a bug, please provide the steps to reproduce.

yarn add web3-core
What is the expected behavior?

correctly resolve latest tag dependencies

Please mention your node.js, yarn and operating system version.

yarn 0.27.5
osx 10.12.6
node v8.2.1

@Haroenv
Copy link
Member

Haroenv commented Aug 19, 2017

You can probably work around this by installing web3-core@latest, even though this seems like an issue that should be solved.

@ewingrj
Copy link
Author

ewingrj commented Aug 19, 2017

unfortunately, that doesn't seem to work. It seems to be using the incorrect package.json.

With yarn add web3-core@latest I get the error:

Couldn't find any versions for "web3-utils" that matches "^1.1.0"

The package.json is here: https://unpkg.com/web3-core@latest/package.

But it appears to be installing 1.1.0 package.json: https://unpkg.com/web3-core@1.1.0/package.json

@BYK
Copy link
Member

BYK commented Aug 25, 2017

I think this is because of our special treatment to version latest. Looks like we should favor dist-tags where as we don't.

@BYK BYK changed the title yarn resolves dependencies differently then npm Yarn should make better use of dist-tags Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants