Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn upgrade-interactive doesn't seem to find out all the latest version of pkg.json #3460

Closed
hjl19911127 opened this issue May 20, 2017 · 3 comments

Comments

@hjl19911127
Copy link

This is my pkg.json ,as u can see the version of vue-router is ^2.3.1

image

when i run yarn upgrade-interactive ,it says :

image

but the latest version of vue-router is 2.5.3

image

then i run yarn upgrade vue-router

image

I hope any one could help me find how the two commands have different results.

@kaylie-alexa
Copy link
Member

I think this is happening because on the latest install, your vue-router package was already updated to 2.5.3 and modified yarn.lock's version. Since upgrade-interactive command checks the version field in the existing lockfile (version is 2.5.3, and satisfies ^2.3.1) , it technically is up-to-date. On the other hand, upgrade [package] command does a fresh install based on latest tag and would update the required version in package.json from ^2.3.1 to ^2.5.3. I guess upgrade-interactive should also update the requirements in package.json if the range is lower than the installed version, but I'd like to hear from others what the best approach would be.

@BYK
Copy link
Member

BYK commented Oct 30, 2017

Closing due to lack of activity and responses.

@bkniffler
Copy link

I think that upgrade-interactive should update package.json accordingly, as @kaylieEB suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants