Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to cherry-pick in [0.17-stable] #1859

Closed
16 tasks done
bestander opened this issue Nov 15, 2016 · 16 comments
Closed
16 tasks done

Fixes to cherry-pick in [0.17-stable] #1859

bestander opened this issue Nov 15, 2016 · 16 comments
Assignees

Comments

@bestander
Copy link
Member

bestander commented Nov 15, 2016

0.17.0


0.17.2 branch cut


0.17.3 branch cut


0.17.4 branch cut


0.17.6 branch cut


0.17.7, 0.17.8 branch cut


0.17.9 branch cut


0.17.10 branch cut

---- NOT CHERRY PICKED, WILL BE RELEASED IN 0.18

@dbashford
Copy link

If this is you guys figuring out what needs to be prioritized for the next release... I think #1823 has made Yarn unusable for a lot of folks.

@bestander
Copy link
Member Author

Thanks, @dbashford, yes, help with prioritization, fixes and tests is very much welcome

@cpojer
Copy link
Contributor

cpojer commented Nov 15, 2016

Thanks @bestander for trying to be on top of this. I know it's hard with all the issues/PRs coming in. Once we get to better test coverage we should figure out how we can focus on making the project a bit less of a burden to maintain :)

@bestander bestander changed the title Fixes to cherry-pick in [0.17.1] Fixes to cherry-pick in [0.17-stable] Nov 16, 2016
@bestander
Copy link
Member Author

0.17.3 is being deployed, please send more PRs and let us know what is the highest pri now

@KidkArolis
Copy link
Contributor

Consider pulling in #1666, it fixes yarn for use with private authenticated registries.

@bestander
Copy link
Member Author

@KidkArolis I've added it to the list but to the bottom considering that it is still in progress and is not a regression (right?).

@KidkArolis
Copy link
Contributor

Thanks, nw.

@Daniel15
Copy link
Member

I think the roadrunner.json issue is fairly important to fix.

@bestander
Copy link
Member Author

Everything that people could consistently reproduce has been fixed and cherry-picked into 0.17.4 which is being released now.

@SimenB
Copy link
Contributor

SimenB commented Nov 17, 2016

@bestander #761

@bestander
Copy link
Member Author

@SimenB, I understand this is an ongoing issue and not a regression.

@SimenB
Copy link
Contributor

SimenB commented Nov 17, 2016

It was made worse in 0.17. We had yarn --prod which worked, and with 0.17 it broke. My repro breaks in both 0.16 and 0.17 though

@bestander
Copy link
Member Author

@SimenB, ok, we'll get this in

@bestander bestander self-assigned this Nov 27, 2016
@owais
Copy link

owais commented Nov 29, 2016

Just tried 0.17.9 on OS X but it still doesn't seem to fix the private tarballs issue. Should I open another issue for this or did we not actually roll out the fix yet?

Trace:
  Error: http://npm.mycompany.com/@/@my-company/mypackage/_attachments/mypackage-3.7.2.tgz: invalid tar file
      at Extract.Parse._startEntry (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/tar/lib/parse.js:149:13)
      at Extract.Parse._process (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/tar/lib/parse.js:131:12)
      at BlockStream.<anonymous> (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/tar/lib/parse.js:47:8)
      at emitOne (events.js:96:13)
      at BlockStream.emit (events.js:188:7)
      at BlockStream._emitChunk (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/block-stream/block-stream.js:145:10)
      at BlockStream.flush (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/block-stream/block-stream.js:70:8)
      at BlockStream.end (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/block-stream/block-stream.js:66:8)
      at Extract.Parse.end (/usr/local/Cellar/yarn/0.17.9/libexec/lib/node_modules/yarn/node_modules/tar/lib/parse.js:86:23)
      at UnpackStream.onend (_stream_readable.js:511:10)

@bestander
Copy link
Member Author

Hey guys, I'd like to not cherry-pick the last two:
Scoped package installation sometimes fails on Windows #1861 (fix #1866)
authentication for scoped private registry tarballs #1666 #1318

And release 0.18.0 with them during the weekend.
Cherry-picking got a bit harder with master branch diverging

@bestander
Copy link
Member Author

0.18 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants