Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh:// prefix is not removed from URLs passed to git CLI #1796

Closed
kornelski opened this issue Nov 12, 2016 · 0 comments
Closed

ssh:// prefix is not removed from URLs passed to git CLI #1796

kornelski opened this issue Nov 12, 2016 · 0 comments

Comments

@kornelski
Copy link
Contributor

kornelski commented Nov 12, 2016

Bug in v0.17.0. Still in v0.20.3.

What is the current behavior?

URL in the format git+ssh://host_alias:path.git is given to git clone as ssh://host_alias:path.git. This is not compatible with npm, which clones host_alias:path.git (without the ssh:// prefix). This changes the meaning of the URL in git.

(By host_alias I mean a name given in Host setting in ~/.ssh/config. I'm using git URLs in such format, because it allows me to configure specific SSH deployment keys for private github repos.)

What is the expected behavior?

ssh:// prefix should be stripped from URLs given to git CLI.

Please mention your node.js, yarn and operating system version.

yarn v0.17.0-20161111.1922. Tested again in v0.20.3.

#513 says git+ssh support is fixed, but this particular case still doesn't work for me in today's nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants