Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package.json saving optional during upgrade #1511

Closed
dkrutsko opened this issue Oct 27, 2016 · 2 comments
Closed

Make package.json saving optional during upgrade #1511

dkrutsko opened this issue Oct 27, 2016 · 2 comments

Comments

@dkrutsko
Copy link

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
When updating packages with yarn upgrade, it overwrites the package.json file and messes up all my custom formatting.

What is the expected behavior?
yarn upgrade should work like npm update where it updates the packages based on the current package.json file with an optional command to save those changes back. It gets very hard to maintain a project with a lot of dependencies when the package.json file is all messed up. Please give me the option to manually maintain my package.json files.

Please mention your node.js, yarn and operating system version.
Node 6.9.1 LTS with Yarn 0.16.1 on OSX 10.11.4

@wyze
Copy link
Member

wyze commented Nov 15, 2016

This is along the same lines as #1743 and you can see why we wont do this here: #1743 (comment)

@wyze wyze closed this as completed Nov 15, 2016
@wyze wyze added wontfix and removed needs triage labels Nov 15, 2016
@dkrutsko
Copy link
Author

@wyze: It's not really the same though, that issue is referring to adding packages which would understandably have to modify the package.json file. Why should upgrade overwrite it though. It doesn't change anything in the file apart from the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants