Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site redirecting to /lang/en/ instead of /en/ #1031

Open
Daniel15 opened this issue Dec 11, 2019 · 6 comments
Open

Site redirecting to /lang/en/ instead of /en/ #1031

Daniel15 opened this issue Dec 11, 2019 · 6 comments

Comments

@Daniel15
Copy link
Member

Need to investigate why the https://yarnpkg.com/ redirect is playing up.

@Daniel15
Copy link
Member Author

@Haroenv Any ideas here?

@Haroenv
Copy link
Member

Haroenv commented Dec 11, 2019

hmm, it doesn't redirect to lang/en for me, what are your accept-language headers? for me https://yarnpkg.com/ goes to https://yarnpkg.com/en

@arye-eidelman
Copy link

arye-eidelman commented Jan 26, 2020

https://yarn.pm/react redirects me to https://legacy.yarnpkg.com/en/lang/en/package/react which displays a 404.
This is clearly specifying the language twice, removing "/lang/en" gets me to the right page at https://legacy.yarnpkg.com/en/package/react

@Haroenv
Copy link
Member

Haroenv commented Jan 27, 2020

I can replicate this now, but I'm not sure how to debug this. My guess is something with the new website, but old redirects somehow?

@Daniel15
Copy link
Member Author

@arye-dov-eidelman - Thanks for the report. I think that's due to some bad redirects on the new site. It's redirecting:

The new site shouldn't be inserting /lang/ in the URL. I submitted yarnpkg/berry#802 to fix that.

I also updated yarn.pm to go directly to the legacy site, bypassing the broken redirect on the 'new' site (yarnpkg/release-infra@667c9a4) which should fix it.

@Daniel15
Copy link
Member Author

Actually I just realised that the package listing DOES exist on the new site, just without the /en/ in the URL. I'll update the redirect to go to the non-/en/ version instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants