Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less eager help command execution #972

Merged
merged 1 commit into from Oct 13, 2017
Merged

fix: less eager help command execution #972

merged 1 commit into from Oct 13, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Oct 13, 2017

Now that yargs is being used to build chat bots in a few places, the eager help command feels like more of a hinderance than a help; It's relatively rare that help ends a sentence, but it's fairly frequent for help to show up somewhere in a natural language string (triggering help output in a chat bot).

This is a breaking change:

  • we no longer allow a single character help command to trigger help output.
  • a help command must now be at the end of a sequence of commands to trigger output.

fixes #676

BREAKING CHANGE: help command now only works if it's the las command in a list.

CC: @zkat

BREAKING CHANGE: help command now only works if it's the las command in a list.
@bcoe bcoe merged commit 8c1d7bf into master Oct 13, 2017
@bcoe bcoe deleted the less-eager-help branch October 13, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

super eager help command execution
1 participant