Updated yargs.js to allow both undefined and nulls #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript requires the usage of undefined instead of null - this update allows both.
|
The main reason for this, if I use "null" then the TypeScript Compiler fails as it needs undefined instead of null. And if i use undefined then yargs fails as it requires a number or null. This hopefully fixes yargs for people using TS. |
|
@mike-weshop thanks for the contribution; off the top of my head I can't think of why accepting both |
|
@mike-weshop your work is scheduled to go out the door in the next release of yargs. Mind helping me test? You can do so by running:
|
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript requires the usage of undefined instead of null - this update allows both.