BugFix: Exclude positional arguments from completion output #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
changed the title
|
@IvanGoncharov thanks for this contribution! and sorry for the slow reply, I've been a bit buried in open-source tickets, and also dealing with some stressful personal stuff. In an effort to speed up development, I've created a community slack for yargs: http://devtoolscommunity.herokuapp.com/ Would love to have you join, so that we can coordinate landing this and future patches. |
bcoe
reviewed
Aug 15, 2017
test/completion.js
Outdated
| @@ -118,7 +118,7 @@ describe('Completion', function () { | |||
|
|
|||
| it('does not complete hidden commands', function () { | |||
| var r = checkUsage(function () { | |||
| return yargs(['./completion', '--get-yargs-completions', 'cmd']) | |||
| return yargs(['./completion', '--get-yargs-completions']) | |||
There was a problem hiding this comment.
curious as to why this change was needed?
|
@IvanGoncharov thanks for the contribution 👍 |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #818 + Added test