feat: allow extends to load configuration from a module #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than adding more configuration for the
extends
feature, I've opted to simplify our logic somewhat:it's now always assumed that either:
pkgConf
orconfig
, points to the absolute path of a configuration file -- this approach might not solve 100% of use-cases, but I like how much it simplifies the problem.BREAKING CHANGE: extends functionality now always loads the JSON provided, rather than reading from a specific key
@rcoy-v great work on the
extends
feature; I'm really excited to pull this intonyc
.