Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commands are now applied in order, from left to right #857

Merged
merged 2 commits into from Apr 29, 2017
Merged

fix: commands are now applied in order, from left to right #857

merged 2 commits into from Apr 29, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Apr 15, 2017

BREAKING CHANGE: commands will now not be executed if they are proceeded by another positional argument

fixes: #853

CC: @gajus

@bcoe bcoe requested a review from JaKXz April 15, 2017 21:35
JaKXz
JaKXz approved these changes Apr 15, 2017
View reviewed changes
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more comments the better [for me] :)

Seems simple enough. 👍

@bcoe bcoe mentioned this pull request Apr 15, 2017
Closed
@bcoe bcoe merged commit baba863 into master Apr 29, 2017
This was referenced Nov 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of strict() with extra args
2 participants
@bcoe @JaKXz