fix: we shouldn't output help if we've printed a prior help-like message #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
reviewed
Apr 1, 2017
test/yargs.js
Outdated
| .help() | ||
| .recommendCommands() | ||
|
|
||
| parser.parse('boat help', {}, function (_err, argv, output) { |
There was a problem hiding this comment.
It might be redundant, but shouldn't we check that error is null/falsy here? and shouldn't it be _argv since we're not using that arg?
JaKXz
approved these changes
Apr 1, 2017
maxrimue
approved these changes
Apr 1, 2017
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were accidentally printing the help text twice, if recommendations were made and
exit = false.Let's not do this, it looks weird!
fixes #822