Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): fix demandOption ignores false value #829

Merged
merged 1 commit into from Mar 22, 2017
Merged

fix(*): fix demandOption ignores false value #829

merged 1 commit into from Mar 22, 2017

Conversation

bricss
Copy link
Contributor

@bricss bricss commented Mar 17, 2017

Bugfix -> #827

@bcoe
Copy link
Member

bcoe commented Mar 17, 2017

@bricss awesome! thanks for the contribution.

bcoe
bcoe approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bricss thanks for the contribution 👍

@bcoe bcoe merged commit c748dd2 into yargs:master Mar 22, 2017
This was referenced Nov 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bricss @bcoe