Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: still freeze/unfreeze if parse() is called in isolation #717

Merged
merged 2 commits into from Nov 27, 2016
Merged

fix: still freeze/unfreeze if parse() is called in isolation #717

merged 2 commits into from Nov 27, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Nov 27, 2016

I see no reason for us to not still call freeze()/unfreeze() to put yargs back into an initial state when parse() is called in isolation.

@bcoe bcoe mentioned this pull request Nov 27, 2016
Merged
lrlna
lrlna approved these changes Nov 27, 2016
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoe this looks good to me ^_^

maxrimue
maxrimue approved these changes Nov 27, 2016
View reviewed changes
Copy link
Member

@maxrimue maxrimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bcoe bcoe merged commit 30a9492 into master Nov 27, 2016
@bcoe bcoe deleted the 710-fix branch November 27, 2016 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrimue maxrimue maxrimue approved these changes

@lrlna lrlna lrlna approved these changes

Assignees

@nexdrew nexdrew

@lrlna lrlna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoe @maxrimue @lrlna @nexdrew