Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to yargs-parser that addresses #598, #617 #700

Merged
merged 1 commit into from Nov 11, 2016
Merged

feat: update to yargs-parser that addresses #598, #617 #700

merged 1 commit into from Nov 11, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Nov 7, 2016

@ssonal this upgrades us to the next release of yargs-parser, which introduces your support for #598, #617. Go ahead and take it for a spin 馃憤

ssonal
ssonal approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@ssonal ssonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works as expected 馃槂

@bcoe
Copy link
Member Author

bcoe commented Nov 10, 2016

@maxrimue @lrlna does this look reasonable?

@lrlna
Copy link
Member

lrlna commented Nov 10, 2016

@bcoe 馃挴

@bcoe bcoe merged commit 54cb31d into master Nov 11, 2016
@bcoe bcoe deleted the upgrade-yargs-parser branch November 11, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssonal ssonal ssonal approved these changes

@lrlna lrlna lrlna approved these changes

Assignees

@maxrimue maxrimue

@lrlna lrlna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoe @lrlna @ssonal @maxrimue