Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a context object with circular references will explode the stack on parse #671

Closed
ceejbot opened this issue Oct 16, 2016 · 1 comment
Closed

Comments

@ceejbot
Copy link

ceejbot commented Oct 16, 2016

I'm attempting to use the new headless parsing feature to write a Slack bot, following the example in the pirate joe repo. If I pass a context object to the parse() command that happens to include circular references (as many node http request clients or messages do), yargs will never succeed in parsing it. Eventually the process will exceed the maximum call stack size and crash.

In my particular case, I made an RTM client using the @slack/client module and hung it onto the context object. That should suffice to repro.

@nexdrew
Copy link
Member

nexdrew commented Oct 19, 2016

Closing since this was fixed by #675. Thanks for reporting!

@nexdrew nexdrew closed this as completed Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants