Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove one call to reset(), fix: freeze was not resetting config objects. #670

Merged
merged 3 commits into from Oct 15, 2016
Merged

perf: remove one call to reset(), fix: freeze was not resetting config objects. #670

merged 3 commits into from Oct 15, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Oct 15, 2016 •
edited

  • perf: addresses the performance issue @nexdrew noted, related to calling reset() more times than necessary.
  • fix: we now freeze config-objects, allowing a new context to be passed to consecutive runs to parse().

CC: @nexdrew

@bcoe bcoe mentioned this pull request Oct 15, 2016
Merged
@bcoe bcoe changed the title perf: remove one call to reset() perf: remove one call to reset(), fix: freeze was not resetting config objects. Oct 15, 2016
@bcoe bcoe merged commit ae4bcd4 into master Oct 15, 2016
@bcoe bcoe deleted the remove-reset-call branch October 15, 2016 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bcoe