Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop lodash.assign #641

Merged
merged 1 commit into from Sep 30, 2016
Merged

fix: drop lodash.assign #641

merged 1 commit into from Sep 30, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 30, 2016

lodash.assign is now deprecated; given how simple our use-case is, I opted to simply add the functionality to yargs itself.

@bcoe bcoe merged commit ad3146f into master Sep 30, 2016
@bcoe bcoe deleted the drop-lodash.assign branch September 30, 2016 07:11
@jdalton
Copy link

jdalton commented Oct 7, 2016

There's object.assign by @ljharb so you can shim Object.assign and use it in Node 0.10 or 0.12.
It comes with a variety of ways to load it, with and without augmenting the built-in.

It's also worth noting that the lodash.assign deprecation is just an npm console log when installed. Nothing else was changed.

I actually pulled the deprecation message because gulp (Blaine) threaten to pull Lodash out of all of their packages. It, the console log, isn't worth that much drama TBH.

@bcoe
Copy link
Member Author

bcoe commented Oct 8, 2016

@jdalton I can understand your perspective; nightly canary builds for Chrome, and other browsers, have worked wonderfully, and in the past few years this approach to releasing software has moved forward browser technologies phenomenally.

At the same time, older versions of Node.js come installed on a lot of machines, e.g., sudo yum install nodejs, and a lot of new users might not be savvy enough to keep their engine up-to-date...

In both yargs and nyc, I'm trying to figure out a balance of supporting legacy versions of Node.js, and continuing to move forward with the ecosystem. There are interesting challenges, for instance npm itself will likely support Node 0.10 for quite some time and is a user of nyc (add to this, nyc is a power user of yargs).

I plan to chat with @othiym23, and the rest of the CLI team, to figure out an appropriate cadence for dropping Node 0.10 support.

I apologize if I contributed to drama in the twitersphere.

@jdalton
Copy link

jdalton commented Oct 8, 2016

I can understand your perspective; nightly canary builds for Chrome, and other browsers, have worked wonderfully, and in the past few years this approach to releasing software has moved forward browser technologies phenomenally.

Nothing really nightly or canary about it. I used the deprecation log to encourage folks to start using syntax which is supported by the soon-to-be min bar of stable/LTS Node 4 and 6 as well as all stable evergreen browsers like Chrome, Edge, Firefox, Opera, & Safari. That's kinda the point of deprecation vs. discontinuation. That said, that specific deprecation was probably a little premature ;P

I apologize if I contributed to drama in the twitersphere.

Oh boy, more than twitersphere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants