Also pass yargs to the fail handler

[mkawalec]

This is needed to display a complete help message for a command that failed in a top-level fail handler

[bcoe]

@mkawalec love it. 👍

[mkawalec]

@bcoe: Should I change something, or can we merge this? :)

[bcoe]

@mkawalec sorry for the slow turnaround! looks great, but could I perhaps get you to add a test? Partially because it would be neat to see how you plan on using this functionality 👍

[mkawalec]

I'll add the test early next week, thanks for the review.

[bcoe]

@mkawalec would love to land this, any news on that test :)

[mkawalec]

@bcoe: I've added the test, but it fails. The reason for that is that the exception thrown in command handler is not caught and so fail is never called. However, in a program I have that uses yargs the fail handler is called if an exception is thrown in the command handler. Is this a problem with the test harness or my mistake somewhere?

[bcoe]

@mkawalec when I have some time this weekend I'll take a look at the harness 👍

[bcoe]

@mkawalec this weekend has quickly become this following weekend, for which I apologize; I haven't forgotten about this pull.

[mkawalec]

No worries @bcoe, I know the pain well :)

[bcoe]

This is looking good! make the slight copy change, and get the test updated, and I'll land this ASAP.

[bcoe]

slight editing nit, let's change this to:

fn is called with the failure message that would have been printed, the
Error instance originally thrown, and the yargs instance when the failure occurred.

[bcoe]

I finally had the time to debug this test for you, here's the code I pulled together:

      it('is invoked with yargs instance as third argument', function () {
        var r = checkUsage(function () {
          return yargs('foo')
            .command('foo', 'desc', {
              bar: {
                describe: 'bar command'
              }
            }, function (argv) {
              throw new Error('blah')
            })
            .fail(function (message, error, yargs) {
              yargs.showHelp()
            })
            .exitProcess(false)
            .wrap(null)
            .argv
        })

        r.errors[0].should.contain('bar command')
      })

[mkawalec]

Thank you. I know it's tiny, I'll find a minute tomorrow to integrate it in this PR

[bcoe]

@mkawalec awesome 👍

[mkawalec]

@bcoe please rereview :)