Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#540 - Changed parsing of the command string to ignore extra spaces #600

Merged
merged 1 commit into from Aug 20, 2016
Merged

#540 - Changed parsing of the command string to ignore extra spaces #600

merged 1 commit into from Aug 20, 2016

Conversation

jmbyerly
Copy link
Contributor

Changed the parsing of the command string to ignore extra spaces between positional arguments, rather than create an additional required positional argument with a value of an empty string for each extra space. Wrote a test to confirm the fix.

@maxrimue
Copy link
Member

This looks great, thanks for working out the fix! 👍 Btw, if you wonder why Travis failed, it's not because of your code but because of #596

@jmbyerly
Copy link
Contributor Author

Ah okay, yeah I was wondering about that. I checked out some of the other open pull requests and saw that they were throwing the same error so I was guessing (and hoping!) that it was unrelated to my code. Thanks for confirming, that's definitely a relief! Glad my first pull request went off without a hitch!

@bcoe
Copy link
Member

bcoe commented Aug 20, 2016

@jmbyerly great contribution, tests much appreciated.

@bcoe bcoe merged commit e8e5a72 into yargs:master Aug 20, 2016
@jmbyerly jmbyerly deleted the 540 branch August 20, 2016 00:24
@bcoe
Copy link
Member

bcoe commented Sep 30, 2016

@jmbyerly could you please give this a spin, I'd like to roll this out soon to get rid of a deprecation notice:

npm cache clear; yargs@6.0.0-alpha.1

thanks for the contribution.

@jmbyerly
Copy link
Contributor Author

jmbyerly commented Oct 1, 2016

@bcoe Apologies, I'm new to coding and am a bit unclear as to what you mean. Should I run this on my local copy of the repo and verify that it's running without the deprecation notice? I'm happy to help out any way that I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants