feat: apply .env() globally #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nexdrew I'm comfortable calling this a fix, I think this is closer to what the expected behavior would be -- can't think of a case where you'd want to drop |
|
@nexdrew alternatively, we could just call this the first which relates to the fact that |
nexdrew
force-pushed
the
apply-envPrefix-globally
branch
from
aaec7bf
to
bc3e5d5
Compare
bcoe
force-pushed
the
apply-envPrefix-globally
branch
from
bc3e5d5
to
eaa2873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486.
This means that a configured
envPrefixwill not be reset for nested commands.This could potentially be considered a breaking change since env vars that used to be ignored for the execution of command handlers may no longer be ignored. 馃槷 Otherwise, this could be considered a fix. 馃槙