fix: lazy-load package.json and cache. get rid of pkg-conf dependency. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewers: @nexdrew, @marneborn |
|
tested this thoroughly on the |
This was referenced Jul 9, 2016
| options.configObjects = (options.configObjects || []).concat(conf) | ||
| } | ||
|
|
||
| return self | ||
| } | ||
|
|
||
| var pkg = null | ||
| function pkgUp (path) { | ||
| if (pkg && !path) return pkg |
There was a problem hiding this comment.
There's a slight bug with this logic. If pkgUp is called first with a path (as in .pkgConf('kewl', process.cwd())) and then subsequently without a path (as in .version()), the parsed pkg object returned will be from the call with the path, which is most likely the wrong package.json file.
To fix, we should probably cache a map of path -> pkg object and return the cached object that matches the given path (normalized to '__no_path__' or something similar).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we dug into some of the performance concerns with yargs in #521, and came up with an initial quick win.
In this pull request we:
pkg-confin favor of usingread-pkg-upexclusively.read-pkg-up(the require time for modules was leading to some of yargs' bad performance benchmarks).package.jsonthe first time we load it.nexttag and made sure thatpkgConfand yargs configuration continues working as expected.